Skip to content

b4b-dev: Move nml parameters (changes paramfile)#3391

Open
swensosc wants to merge 5 commits intoESCOMP:b4b-devfrom
swensosc:move_nml_parameters
Open

b4b-dev: Move nml parameters (changes paramfile)#3391
swensosc wants to merge 5 commits intoESCOMP:b4b-devfrom
swensosc:move_nml_parameters

Conversation

@swensosc
Copy link
Contributor

@swensosc swensosc commented Aug 7, 2025 •
edited by ekluzek
Loading

Description of changes

move namelist parameters to parameter file. parameters moved are: baseflow_scalar, precip_repartition_nonglc_all_rain_t, precip_repartition_nonglc_all_snow_t, precip_repartition_glc_all_rain_t, precip_repartition_glc_all_snow_t

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? Yes

Does this create a need to change or add documentation? Did you do so? No No

Testing performed, if any: Will run aux_clm to move to b4b-dev

@ekluzek
Copy link
Collaborator

ekluzek commented Aug 7, 2025

I did a quick skim over this and this looks good to me. I'll rebase this PR to go to b4b-dev, which should be fine without any trouble. Sometimes you have to rebase the branch when that's done, but I don't expect that now.

The one thing noticeably missing is an updated parameter file with the parameters moved to it.

@ekluzek ekluzek added next this should get some attention in the next week or two. Normally each Thursday SE meeting. bfb bit-for-bit usability Improve or clarify user-facing options labels Aug 7, 2025
@ekluzek ekluzek added this to the ctsm6.0.0 (code freeze) milestone Aug 7, 2025
@ekluzek
Copy link
Collaborator

ekluzek commented Aug 7, 2025

Adding next to talk about who will shepherd this in.

@ekluzek ekluzek changed the base branch from master to b4b-dev August 7, 2025 15:14
@swensosc
Copy link
Contributor Author

swensosc commented Aug 7, 2025 •
edited by ekluzek
Loading

parameter file location: /fs/cgd/csm/inputdata/lnd/clm2/paramdata/ctsm5.3.041.Nfix_params.v13.c250221_upplim250_add_nml.nc

@ekluzek ekluzek removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Sep 12, 2025
@ekluzek
Copy link
Collaborator

ekluzek commented Sep 12, 2025

We talked about this and will bring it in on b4b-dev.

@ekluzek ekluzek self-assigned this Oct 7, 2025
@ekluzek ekluzek self-requested a review October 7, 2025 16:47
@slevis-lmwg slevis-lmwg self-assigned this Dec 11, 2025
ekluzek
ekluzek approved these changes Dec 11, 2025
View reviewed changes
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had looked at this when this first came in and thought I had already approved. So approving now.

I skimmed through again and didn't notice anything that warrants attention.

@ekluzek ekluzek removed their assignment Dec 11, 2025
@slevis-lmwg slevis-lmwg moved this from Todo to In Progress in LMWG: Sprint Planning Board Dec 12, 2025
@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Dec 15, 2025 •
edited
Loading

Paused testing because need to bring the new params (see post above) to the latest paramfiles:

OK ./build-namelist_test.pl
./run_sys_tests -s aux_clm -c ctsm5.4.001 --skip-generate
./run_sys_tests -s aux_clm -c ctsm5.4.001 --skip-generate --skip-git-status

@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Dec 15, 2025 •
edited
Loading

Before I add the new params to paramfiles:

  • list the latest paramfiles on master and b4b-dev
    master currently ctsm5.4.004 has the latest and Erik tells me that we do not expect other paramfile updates:
<paramfile phys="clm6_0" >lnd/clm2/paramdata/ctsm60_params.c251211.nc</paramfile>
<paramfile phys="clm5_0" >lnd/clm2/paramdata/clm50_params.c250311.nc</paramfile>
<paramfile phys="clm4_5" >lnd/clm2/paramdata/clm45_params.c250311.nc</paramfile>

ctsm60 and clm50 are the paramfiles to update, not clm45.

Consider the new tool in #3622 if needed.

@slevis-lmwg slevis-lmwg added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Dec 15, 2025
@slevis-lmwg slevis-lmwg moved this from In Progress to Stalled in LMWG: Sprint Planning Board Dec 15, 2025
@slevis-lmwg slevis-lmwg removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Dec 18, 2025
@slevis-lmwg slevis-lmwg moved this from Stalled to In Progress in LMWG: Sprint Planning Board Dec 18, 2025
@slevis-lmwg slevis-lmwg changed the title Move nml parameters b4b-dev: Move nml parameters Dec 22, 2025
@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Dec 23, 2025 •
edited
Loading

I generated two new paramfiles with the updates:

/glade/campaign/cesm/cesmdata/inputdata/lnd/clm2/paramdata/clm50_params.c251222.nc
/glade/campaign/cesm/cesmdata/inputdata/lnd/clm2/paramdata/ctsm60_params.c251222.nc
  • Repeat with current paramfile
  • After testing, ./rimport and relink.py

@slevis-lmwg slevis-lmwg moved this from In Progress to Stalled in LMWG: Sprint Planning Board Dec 23, 2025
@github-project-automation github-project-automation bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Jan 12, 2026
@slevis-lmwg slevis-lmwg moved this from Ready to start (or start again) to In progress - b4b-dev in CTSM: Upcoming tags Jan 12, 2026
@github-project-automation github-project-automation bot moved this from Ready to start (or start again) to In progress - master in CTSM: Upcoming tags Jan 12, 2026
@slevis-lmwg slevis-lmwg moved this from In progress - master to In progress - b4b-dev in CTSM: Upcoming tags Jan 12, 2026
@slevis-lmwg
Merge branch 'b4b-dev' into move_nml_parameters
4c335bb 
slevis resolved conflicts:
bld/namelist_files/namelist_defaults_ctsm.xml
@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Jan 13, 2026 •
edited
Loading

To avoid multiple paramfile updates, this PR will now wait for the next master merge to b4b-dev due to a paramfile update that occurred on master a few days ago.

UPDATE 2026/1/29
This PR will wait a bit longer because Linnia has started a new phase of paramfile updates.

@slevis-lmwg slevis-lmwg changed the title b4b-dev: Move nml parameters b4b-dev: Move nml parameters (changes paramfile) Jan 23, 2026
@slevis-lmwg slevis-lmwg moved this from Stalled to In Progress in LMWG: Sprint Planning Board Jan 23, 2026
@slevis-lmwg slevis-lmwg moved this from In Progress to Stalled in LMWG: Sprint Planning Board Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekluzek ekluzek ekluzek approved these changes

Assignees

@slevis-lmwg slevis-lmwg

Labels

bfb bit-for-bit usability Improve or clarify user-facing options

Projects

CTSM: Upcoming tags
Status: In progress - b4b-dev
LMWG: Sprint Planning Board
Status: Stalled

Milestone

ctsm6.0.0 (code freeze)

Development

Successfully merging this pull request may close these issues.

3 participants

@swensosc @ekluzek @slevis-lmwg